Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move to vitejs #733

Merged
merged 19 commits into from
Aug 10, 2023
Merged

feat: move to vitejs #733

merged 19 commits into from
Aug 10, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Aug 7, 2023 •
edited
Loading

In this PR:

  • move to vite for bundling
    • enjoy near instant dev server startup ⏩
    • no more eslint plugin hell 😈
    • faster builds 🏗️
  • fix a lot of ts errors in cypress test files 🩹 🚑
  • tweak the cypress workflow to play nicely with vite:
    1. build the app in test mode with coverage (had to increase the memory limit ...)
    2. start cypress tests with the app in "preview" mode (the built code is served with an http server)
    • this eliminates some failing tests related to WebSockets mocking. Vite uses WebSockets in its dev-server to push HMR updates, if we mock the WebSockets it breaks the tests... Using a build without a dev server eliminates this issue.

Collateral dammage:

  • faster CI: before 45min, now: 30min

To be addressed in up-coming PRs:

@spaenleh spaenleh linked an issue Aug 7, 2023 that may be closed by this pull request
ViteJS #732
Closed
@spaenleh spaenleh self-assigned this Aug 7, 2023
@spaenleh spaenleh added the chore General chore label Aug 7, 2023
@spaenleh spaenleh temporarily deployed to ci August 7, 2023 12:00 — with GitHub Actions Inactive
@spaenleh spaenleh marked this pull request as ready for review August 9, 2023 10:26
@spaenleh spaenleh added the ci label Aug 9, 2023
pyphilia
pyphilia approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible! I've added some comments 🚀

.github/workflows/deploy-prod.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-stage.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-stage.yml Show resolved Hide resolved
cypress/plugins/index.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/item/publish/CCLicenseDialog.jsx Outdated Show resolved Hide resolved
src/components/item/publish/CoEditorSettings.jsx Outdated Show resolved Hide resolved
@spaenleh spaenleh merged commit 9f96a14 into main Aug 10, 2023
@spaenleh spaenleh deleted the 732-vitejs branch August 10, 2023 07:32
@github-actions github-actions bot mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@codeofmochi codeofmochi Awaiting requested review from codeofmochi

Assignees

@spaenleh spaenleh

Labels
chore General chore ci v1.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ViteJS
2 participants
@spaenleh @pyphilia