Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing categories in publishing dialog #704

Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jul 17, 2023

Previously categories could only be deleted by de-selecting them in the drop-down.

This PR fixes the behavior to be able to use the cross icon on the tag to remove the category. Using the backspace also works to remove the latest category.

  • add regression test

@spaenleh spaenleh linked an issue Jul 17, 2023 that may be closed by this pull request
@spaenleh spaenleh requested a review from pyphilia July 17, 2023 19:47
@spaenleh spaenleh self-assigned this Jul 17, 2023
@spaenleh spaenleh added the bug 🪲 Something isn't working label Jul 17, 2023
@spaenleh spaenleh force-pushed the 630-removing-categories-in-publishing-dialog-does-not-work branch from 4119748 to 5b737e5 Compare July 18, 2023 06:21
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I've left a minor comment 🐘

src/components/item/publish/ItemPublishButton.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh merged commit efce7b2 into main Jul 18, 2023
@spaenleh spaenleh deleted the 630-removing-categories-in-publishing-dialog-does-not-work branch July 18, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing categories in publishing dialog does not work
2 participants