feat: refactor favorite items #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganridel
force-pushed
the
refactor-favorite
branch
from
f2c9b89 to
40588e9
Compare
This was referenced Jun 19, 2023
pyphilia
requested changes
Jun 20, 2023
| cy.intercept( | ||
| { | ||
| method: HttpMethod.POST, | ||
| url: new RegExp(`${API_HOST}/${GET_FAVORITE_ITEMS_ROUTE}/${ID_FORMAT}`), |
There was a problem hiding this comment.
It doesn't have to be changes, but if possible you can use the API endpoints from query-client, so it doesn't break if we change the endpoint route.
There was a problem hiding this comment.
The problem is that the endpoint builder takes a UUID to build the url, and the ID_FORMAT is a string
| cy.intercept( | ||
| { | ||
| method: HttpMethod.DELETE, | ||
| url: new RegExp(`${API_HOST}/${GET_FAVORITE_ITEMS_ROUTE}/${ID_FORMAT}`), |
package.json
Outdated
| @@ -147,7 +147,8 @@ | |||
| "nth-check": "2.1.1", | |||
| "react-error-overlay": "6.0.11", | |||
| "@types/react": "17.0.62", | |||
| "@svgr/webpack": "6.5.1" | |||
| "@svgr/webpack": "6.5.1", | |||
| "@graasp/sdk": "github:graasp/graasp-sdk#refactor-favorite" | |||
There was a problem hiding this comment.
Don't forget to change your branches ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.