Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password error overrides choosen password #633

Closed
spaenleh opened this issue Jun 2, 2023 · 0 comments · Fixed by #709
Closed

Password error overrides choosen password #633

spaenleh opened this issue Jun 2, 2023 · 0 comments · Fixed by #709
Labels
bug 🪲 Something isn't working v1.4.0

Comments

@spaenleh
Copy link
Member

spaenleh commented Jun 2, 2023

When password is not strong enough, the error from the db overrides the first password input field, it does not show to the user since these fields are of type="password" by default.

Solution: use the error prop to display the error from the api

Optional enhancement: allow to toggle the visibility of the input using:

<OutlinedInput
  id="outlined-adornment-password"
  type={showPassword ? 'text' : 'password'}
  endAdornment={
    <InputAdornment position="end">
      <IconButton
        aria-label="toggle password visibility"
        onClick={handleClickShowPassword}
        onMouseDown={handleMouseDownPassword}
        edge="end"
      >
        {showPassword ? <VisibilityOff /> : <Visibility />}
      </IconButton>
    </InputAdornment>
  }
  label="Password"
/>

from the MUI TextField examples

@spaenleh spaenleh added the bug 🪲 Something isn't working label Jun 2, 2023
@spaenleh spaenleh linked a pull request Jul 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v1.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant