Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set an altText on images #631

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

MalinSvenberg
Copy link
Contributor

@MalinSvenberg MalinSvenberg commented May 10, 2023

closes #624

Requires change to the backend:

Screenshot 2023-05-10 at 23 45 51

@MalinSvenberg MalinSvenberg marked this pull request as draft May 10, 2023 21:50
@MalinSvenberg MalinSvenberg self-assigned this May 10, 2023
@MalinSvenberg

This comment was marked as outdated.

@MalinSvenberg MalinSvenberg force-pushed the 624-change-alt-text-for-images branch from f605792 to af9ae74 Compare June 19, 2023 00:40
@spaenleh spaenleh force-pushed the 624-change-alt-text-for-images branch from af9ae74 to 68cda69 Compare June 23, 2023 07:33
@spaenleh
Copy link
Member

@MalinSvenberg Was the change shown in the video removed ? I am not sure if i remember correctly but I think there was an issue with the radio button not making it clear that it was simply to toggle between the description and the alt text. Correct me if I am wrong.

@MalinSvenberg
Copy link
Contributor Author

@spaenleh Yes the change in the video was removed. I went back to the first version instead, with only the Name and the Alt text input.

@spaenleh spaenleh force-pushed the 624-change-alt-text-for-images branch from 68cda69 to 5f3373f Compare June 23, 2023 12:01
@spaenleh spaenleh changed the title 624 change alt text for images feat: allow to set an altText on images Jun 23, 2023
@spaenleh spaenleh marked this pull request as ready for review June 26, 2023 07:02
@spaenleh spaenleh requested review from pyphilia and morganridel June 26, 2023 07:02
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌺

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/context/EditItemModalContext.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh self-assigned this Jun 26, 2023
@spaenleh spaenleh force-pushed the 624-change-alt-text-for-images branch from 181a569 to ff01e12 Compare June 26, 2023 14:25
@spaenleh spaenleh merged commit 92f1184 into main Jun 27, 2023
@spaenleh spaenleh deleted the 624-change-alt-text-for-images branch June 27, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to add alt-text to images
3 participants