Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds required symbol for name of folder, document and etherpad #620

Merged
merged 1 commit into from
May 10, 2023
Merged

feat: adds required symbol for name of folder, document and etherpad #620

merged 1 commit into from
May 10, 2023

Conversation

MalinSvenberg
Copy link
Contributor

@MalinSvenberg MalinSvenberg commented May 3, 2023 •
edited
Loading

Closes #619

Adds a * to the name text input field for Folder, Document and Etherpad.

Screenshot 2023-05-03 at 16 16 45

Might want use BaseItemForm in EtherpadForm?

@MalinSvenberg MalinSvenberg self-assigned this May 3, 2023
pyphilia
pyphilia requested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've left a minor comments otherwise it looks nice 🚜

src/components/item/form/BaseItemForm.tsx Show resolved Hide resolved
@codeofmochi codeofmochi merged commit 0d09736 into main May 10, 2023
@codeofmochi codeofmochi deleted the 619-show-name-required branch May 10, 2023 07:10
@github-actions github-actions bot mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofmochi codeofmochi codeofmochi approved these changes

@pyphilia pyphilia pyphilia requested changes

Assignees

@MalinSvenberg MalinSvenberg

Labels
v0.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it clear name is required when creating certain items
3 participants
@MalinSvenberg @pyphilia @codeofmochi