Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve status column display #611

Merged
merged 5 commits into from
Apr 19, 2023
Merged

Improve status column display #611

merged 5 commits into from
Apr 19, 2023

Conversation

spaenleh
Copy link
Member

No description provided.

@spaenleh spaenleh linked an issue Apr 11, 2023 that may be closed by this pull request
Improve styling and display of status badge column #607
Closed
@spaenleh spaenleh marked this pull request as draft April 11, 2023 07:37
@spaenleh spaenleh marked this pull request as ready for review April 14, 2023 08:14
codeofmochi
codeofmochi approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I have a few questions regarding API design as well as some nitpicks

cypress/support/createUtils.js Show resolved Hide resolved
src/components/Root.tsx Outdated Show resolved Hide resolved
src/components/main/ItemsTable.tsx Outdated Show resolved Hide resolved
src/components/table/BadgesCellRenderer.tsx Show resolved Hide resolved
@spaenleh spaenleh mentioned this pull request Apr 19, 2023
Open
@spaenleh spaenleh force-pushed the 607-improve-styling-and-display-of-status-badge-column branch from e84e3ad to fa20a65 Compare April 19, 2023 05:43
@spaenleh spaenleh merged commit ffb6cc5 into main Apr 19, 2023
@github-actions github-actions bot mentioned this pull request Apr 19, 2023
Merged
@spaenleh spaenleh deleted the 607-improve-styling-and-display-of-status-badge-column branch April 19, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofmochi codeofmochi codeofmochi approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees
No one assigned
Labels
improvement v0.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve styling and display of status badge column
2 participants
@spaenleh @codeofmochi