Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close caption on click cancel #606

Conversation

spaenleh
Copy link
Member

No description provided.

@spaenleh spaenleh linked an issue Mar 27, 2023 that may be closed by this pull request
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐶 Just need to update the tests I guess.

cypress/e2e/item/edit/editApp.cy.js Outdated Show resolved Hide resolved
cypress/e2e/item/edit/editLink.cy.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪨

@spaenleh spaenleh merged commit 604318b into main Apr 3, 2023
@spaenleh spaenleh deleted the 582-clicking-on-cancel-button-of-description-does-not-close-editing-view branch April 3, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on cancel button of description does not close editing view
3 participants