Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

490 fix sentry version #581

Merged
merged 4 commits into from
Mar 2, 2023
Merged

490 fix sentry version #581

merged 4 commits into from
Mar 2, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Mar 1, 2023

This PR updates the release field of the sentry config to send [email protected]

It uses the name of the app from the package by reading the json file.
It pulls the version from the REACT_AP_VERSION variable or uses latest as a default.

closes #490

@spaenleh spaenleh linked an issue Mar 1, 2023 that may be closed by this pull request
@spaenleh spaenleh requested review from pyphilia and codeofmochi March 1, 2023 20:40
@spaenleh spaenleh self-assigned this Mar 1, 2023
@spaenleh spaenleh added bug 🪲 Something isn't working chore General chore improvement labels Mar 1, 2023
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please consider my suggestions 🦐

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/config/constants.ts Outdated Show resolved Hide resolved
src/config/constants.ts Show resolved Hide resolved
src/index.tsx Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh merged commit 6dea58c into main Mar 2, 2023
@spaenleh spaenleh deleted the 490-fix-sentry-version branch March 2, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working chore General chore improvement v0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Sentry version
2 participants