-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Share
icon and improve layout of item header actions
#566
Conversation
e46d38d
to
6206972
Compare
6206972
to
701af5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I feel like the new share button is smaller than the other ones?
Thank you for the review @pyphilia. I don't think it is smaller but i might appear a bit smaller due to the design: Do you think it is an issue ? I don't think we should "compensate" visually by making the icon bigger. |
In this PR I propose to change the
Share
icon to better represent that this menu is related to sharing with people.Previously:
Proposed change:
And the link box was styled with the
text-overflow: ellipsis
to better show the link could not be displayed fully:IconButtons were also all wrapped in
span
s to ensure they stay round.TODO:
@graasp/ui
with the changes from 242 change share button icon graasp-ui#245 and graasp/graasp-ui@8877111Change
Favorite Items
icon from a heart to a star to be in ligne with theAdd to Favorites
icon in item actions.closes #550