Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Share icon and improve layout of item header actions #566

Merged
merged 6 commits into from
Feb 24, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Feb 21, 2023

In this PR I propose to change the Share icon to better represent that this menu is related to sharing with people.

Previously:
previously-share-icon

Proposed change:
proposed-share-icon

And the link box was styled with the text-overflow: ellipsis to better show the link could not be displayed fully:
link box

IconButtons were also all wrapped in spans to ensure they stay round.

TODO:

Change Favorite Items icon from a heart to a star to be in ligne with the Add to Favorites icon in item actions.
Capture d’écran 2023-02-21 à 22 58 44

closes #550

@spaenleh spaenleh linked an issue Feb 21, 2023 that may be closed by this pull request
@spaenleh spaenleh requested a review from pyphilia February 21, 2023 13:04
@spaenleh spaenleh self-assigned this Feb 21, 2023
@spaenleh spaenleh added the feature New feature or request label Feb 21, 2023
@spaenleh spaenleh requested a review from codeofmochi February 21, 2023 13:04
@spaenleh spaenleh force-pushed the 550-update-share-icon branch from e46d38d to 6206972 Compare February 21, 2023 22:43
@spaenleh spaenleh force-pushed the 550-update-share-icon branch from 6206972 to 701af5a Compare February 21, 2023 22:47
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I feel like the new share button is smaller than the other ones?

src/components/item/sharing/SharingLink.tsx Outdated Show resolved Hide resolved
@spaenleh
Copy link
Member Author

Thank you for the review @pyphilia. I don't think it is smaller but i might appear a bit smaller due to the design:
Capture d’écran 2023-02-22 à 10 59 59
Capture d’écran 2023-02-22 à 10 59 51
Capture d’écran 2023-02-22 à 10 59 42

Do you think it is an issue ? I don't think we should "compensate" visually by making the icon bigger.
Do you see an icon in the MUI Material Icons list that would be better suite ?
Maybe the Group icon which displays 2 people instead of 3 ?

@spaenleh spaenleh merged commit 5238321 into main Feb 24, 2023
@spaenleh spaenleh deleted the 550-update-share-icon branch February 24, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Share" icon
2 participants