Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tutorial footer menu item #546

Merged
merged 3 commits into from
Feb 7, 2023
Merged

feat: add tutorial footer menu item #546

merged 3 commits into from
Feb 7, 2023

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Feb 6, 2023

close #545

Screenshot 2023-02-06 at 15 55 47

After some feedback I've been suggested to add the tutorials' link at some place in builder. I think the footer is a good place so it's not too highlighted, but I'm happy to get your feedback.

@pyphilia pyphilia requested a review from codeofmochi February 6, 2023 15:09
@pyphilia pyphilia self-assigned this Feb 6, 2023
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📻 maybe in the future we should make the link dynamic, so that we can change the resource or implementation transparently. It looks good otherwise IMO 👍

src/config/constants.ts Show resolved Hide resolved
@pyphilia pyphilia merged commit 9454fdc into main Feb 7, 2023
@pyphilia pyphilia deleted the 545-tutorial-link branch February 7, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tutorial link
2 participants