Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use pdf viewer #504

Merged
merged 2 commits into from
Nov 25, 2022
Merged

feat: use pdf viewer #504

merged 2 commits into from
Nov 25, 2022

Conversation

pyphilia
Copy link
Contributor

close #502

@pyphilia pyphilia self-assigned this Nov 22, 2022
@pyphilia pyphilia requested a review from spaenleh November 22, 2022 11:36
spaenleh
spaenleh approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

codeofmochi
codeofmochi approved these changes Nov 24, 2022
View reviewed changes
cypress/fixtures/fileLinks.js Show resolved Hide resolved
@pyphilia pyphilia mentioned this pull request Nov 25, 2022
Open
@pyphilia pyphilia merged commit 3157958 into master Nov 25, 2022
@pyphilia pyphilia deleted the 502-file-url branch November 25, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@codeofmochi codeofmochi codeofmochi approved these changes

Assignees

@pyphilia pyphilia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use File Url and Pdf Viewer for item
3 participants
@pyphilia @codeofmochi @spaenleh