Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change navigation: Player button should lead to the context item #469

Closed
pyphilia opened this issue Oct 25, 2022 · 2 comments · Fixed by #544
Closed

Change navigation: Player button should lead to the context item #469

pyphilia opened this issue Oct 25, 2022 · 2 comments · Fixed by #544
Assignees
@codeofmochi

Comments

@pyphilia
Copy link
Contributor

Current behavior: in the itemA screen, if you click on the Player option in the navigation mode (top-left button) it leads to the homepage.

Wanted behavior: the button should lead to the player view of itemA
@codeofmochi
Copy link
Contributor

codeofmochi commented Oct 31, 2022 •
edited
Loading

Change design to icon switch: can use Pagination component with hideNextButton and hidePrevButton set to true. Also use new icons from design.

@codeofmochi codeofmochi mentioned this issue Jan 11, 2023
Open
@codeofmochi
Copy link
Contributor

codeofmochi commented Jan 30, 2023 •
edited
Loading

See graasp/graasp-ui#215
This is implemented by #543

@codeofmochi codeofmochi linked a pull request Feb 7, 2023 that will close this issue
feat: add platform switch to builder #544
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeofmochi codeofmochi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add platform switch to builder graasp/graasp-builder
2 participants
@pyphilia @codeofmochi