Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add description to tag modal #1599

Merged
merged 2 commits into from
Dec 19, 2024
Merged

feat: add description to tag modal #1599

merged 2 commits into from
Dec 19, 2024

Conversation

pyphilia
Copy link
Contributor

This PR adds some information about tags in the modal setting.

Please leave some comments about the text, I will refine the PR afterwards.

Screenshot 2024-12-12 at 16 54 27

@pyphilia pyphilia self-assigned this Dec 12, 2024
@spaenleh spaenleh force-pushed the main branch 2 times, most recently from 0791683 to b513c2f Compare December 16, 2024 09:19
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags are simple words or phrases added to content to describe its main topics or themes. These tags make it easier to find content related to those topics when you search. Find more information here

Tags are pieces of data that you can attach to your collections. They describe the subject, context, project, or intended audience of your collections. They help other users to find your content when they search in the library. You can find out more about tags in the documentation

@pyphilia pyphilia marked this pull request as ready for review December 18, 2024 09:27
@pyphilia pyphilia force-pushed the 1598-tag-description branch from 41bdf14 to c2d942b Compare December 18, 2024 09:28
@pyphilia pyphilia requested a review from spaenleh December 18, 2024 16:29
src/langs/en.json Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Basile 🫠

src/langs/en.json Outdated Show resolved Hide resolved
@pyphilia pyphilia requested a review from MatveyK December 19, 2024 10:06
@pyphilia pyphilia enabled auto-merge December 19, 2024 10:07
@pyphilia pyphilia dismissed MatveyK’s stale review December 19, 2024 10:59

got enough reviews

@pyphilia pyphilia added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 1d396c0 Dec 19, 2024
5 checks passed
@pyphilia pyphilia deleted the 1598-tag-description branch December 19, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants