Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color issues and prefix for new player #1586

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Nov 27, 2024

Updated view of the builder page (there should be no noticeable differences with the previous version):
Screenshot 2024-11-28 at 07 51 59

@spaenleh spaenleh requested review from pyphilia and ReidyT November 27, 2024 14:35
@spaenleh spaenleh self-assigned this Nov 27, 2024
@spaenleh spaenleh added bug 🪲 Something isn't working ui labels Nov 27, 2024
@spaenleh spaenleh requested a review from MatveyK November 28, 2024 08:42
Copy link

@MatveyK MatveyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Good job.

Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not against moving towards the new urls, but we should be ready for deployment then.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐦‍🔥 I agree with Kim 🎃

@spaenleh spaenleh added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit d93fa3d Nov 29, 2024
5 checks passed
@MatveyK MatveyK deleted the 1585-secondary-color-bug branch December 3, 2024 08:29
@spaenleh spaenleh mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working ui v2.48.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants