Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: factor out create link modal #1566

Merged
merged 3 commits into from
Nov 12, 2024
Merged

feat: factor out create link modal #1566

merged 3 commits into from
Nov 12, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Nov 7, 2024 •
edited
Loading

This PR updates the create link modal to fully use react-hook-form.

ref #1551

@pyphilia pyphilia requested review from spaenleh and ReidyT November 7, 2024 15:26
@pyphilia pyphilia self-assigned this Nov 7, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.4% Duplication on New Code

See analysis details on SonarCloud

spaenleh
spaenleh approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@pyphilia pyphilia added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit cf440b5 Nov 12, 2024
5 checks passed
@graasper graasper mentioned this pull request Nov 12, 2024
Merged
@spaenleh spaenleh deleted the 1551-create-link branch November 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@pyphilia pyphilia

Labels
v2.46.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh