Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: submit individually file data for edit #1552

Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat: submit individually file data for edit #1552

merged 2 commits into from
Oct 28, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Oct 25, 2024 •
edited
Loading

  • Create ShortcutEditForm and apply react-hook-form
  • Modify LinkForm (edit) so it fully uses react-hook-form. It sends itself the editItem request, so we avoid drilling up props.
    • also fix the bug of editing files by sending only altText for editing extra

Once all forms are refactored, next move would be to use specific endpoints for each item type.

ref #1551
close #1522

@pyphilia pyphilia requested review from spaenleh and ReidyT October 25, 2024 15:21
@pyphilia pyphilia mentioned this pull request Oct 25, 2024
Merged
ReidyT
ReidyT approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪐

src/components/item/form/FileForm.tsx Outdated Show resolved Hide resolved
src/components/item/edit/EditModal.tsx Show resolved Hide resolved
src/components/item/edit/EditModal.tsx Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 69191f0 Oct 28, 2024
4 checks passed
@graasper graasper mentioned this pull request Oct 25, 2024
Merged
@pyphilia pyphilia deleted the 1551-file-form branch November 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@pyphilia pyphilia

Labels
v2.44.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split Edit and Create forms, partially move to react-hook-form
2 participants
@pyphilia @ReidyT