Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow press enter to share item #1550

Merged
merged 3 commits into from
Oct 31, 2024
Merged

feat: allow press enter to share item #1550

merged 3 commits into from
Oct 31, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Oct 25, 2024

Use react-hook-form for Sharing item. It allows to press enter to validate form.
Fixed cancel button as well.

@pyphilia pyphilia requested review from spaenleh and ReidyT October 25, 2024 13:15
@pyphilia pyphilia self-assigned this Oct 25, 2024
@pyphilia pyphilia marked this pull request as ready for review October 25, 2024 13:21
@pyphilia pyphilia requested a review from swouf October 25, 2024 13:22
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Can you add a test that cancels the dialog ?

@pyphilia pyphilia requested a review from spaenleh October 28, 2024 09:22
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

Copy link

@pyphilia pyphilia added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit bbe3270 Oct 31, 2024
4 checks passed
@pyphilia pyphilia deleted the share-enter branch November 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants