Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PublicationAttributeContainer #1546

Open
pyphilia opened this issue Oct 24, 2024 · 0 comments
Open

Refactor PublicationAttributeContainer #1546

pyphilia opened this issue Oct 24, 2024 · 0 comments

Comments

@pyphilia
Copy link
Contributor

          Regarding openness of the props, I would propose to refactor in another PR where users of this component also define empty and filled component eg:
// LicenseContainer.tsx

content={hasNoData ? buildEmptyPlaceHolder() : content}
tooltip={hasNoData && <Warning ... />}
...

Originally posted by @pyphilia in #1543 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant