Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show hidden setting in visibility section #1488

Merged
merged 3 commits into from
Oct 4, 2024
Merged

feat: show hidden setting in visibility section #1488

merged 3 commits into from
Oct 4, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Oct 1, 2024

Screenshot 2024-10-01 at 14 23 30 Screenshot 2024-10-01 at 14 23 10

Inherited
Screenshot 2024-10-01 at 14 20 54

fix #1486

@pyphilia pyphilia requested review from spaenleh and ReidyT October 1, 2024 12:42
@pyphilia pyphilia self-assigned this Oct 1, 2024
ReidyT
ReidyT requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I'm not sure about one condition, so I'll leave it to you to check, and I've also left you a few suggestions. ☕️

src/components/hooks/useVisibility.tsx Outdated Show resolved Hide resolved
src/components/item/sharing/HideSettingCheckbox.tsx Outdated Show resolved Hide resolved
src/components/item/sharing/HideSettingCheckbox.tsx Outdated Show resolved Hide resolved
src/components/item/sharing/HideSettingCheckbox.tsx Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
spaenleh
spaenleh approved these changes Oct 3, 2024
View reviewed changes
src/components/hooks/useVisibility.tsx Outdated Show resolved Hide resolved
src/components/item/sharing/ItemSharingTab.tsx Show resolved Hide resolved
src/components/item/sharing/HideSettingCheckbox.tsx Outdated Show resolved Hide resolved
src/components/item/sharing/membershipTable/GuestItemMembershipTableRow.tsx Outdated Show resolved Hide resolved
src/components/item/sharing/membershipTable/GuestItemMembershipTableRow.tsx Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
@pyphilia pyphilia requested a review from ReidyT October 3, 2024 15:14
ReidyT
ReidyT approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes 🚀

@pyphilia pyphilia force-pushed the 1486-hidden-visibility branch from 75511de to dc3e85c Compare October 4, 2024 11:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
22.6% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge October 4, 2024 11:41
@pyphilia pyphilia added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 0e1bed2 Oct 4, 2024
4 checks passed
@graasper graasper mentioned this pull request Oct 4, 2024
Merged
@spaenleh spaenleh deleted the 1486-hidden-visibility branch October 7, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
v2.42.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show hidden state in visibility
3 participants
@pyphilia @spaenleh @ReidyT