Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define container for drag selection #1481

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

pyphilia
Copy link
Contributor

This PR defines container in which the user can drag-select the cards. It uses a hack to allow margins (defined by a container wrapper) to be part of the selection.

fix #1471

@pyphilia pyphilia added the bug 🪲 Something isn't working label Sep 26, 2024
@pyphilia pyphilia requested a review from ReidyT September 26, 2024 09:13
@pyphilia pyphilia self-assigned this Sep 26, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, LGTM! I'd just extract the "hack" in its own component. What do you think?

src/components/item/FolderContent.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia force-pushed the 1471-text-hover-selection branch from b449f08 to 8ac8fed Compare September 27, 2024 07:58
@pyphilia pyphilia enabled auto-merge September 27, 2024 09:14
@pyphilia pyphilia requested a review from ReidyT September 27, 2024 09:28
Copy link

Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change 🥳

@pyphilia pyphilia added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 62081e2 Sep 27, 2024
4 checks passed
@pyphilia pyphilia deleted the 1471-text-hover-selection branch September 27, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v2.41.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot text select description because of selection drag
2 participants