Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Thumbnails from PackedItem #1468

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat: use Thumbnails from PackedItem #1468

merged 1 commit into from
Sep 27, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Sep 20, 2024 •
edited
Loading

This PR use the new PackedItem containing directly the thumbnails urls. I stopped using useItemThumbnailUrl hook.

I also use ImageUploader in settings:

Before:

image

After:

image

On hover:

image

@ReidyT ReidyT self-assigned this Sep 20, 2024
@ReidyT ReidyT force-pushed the 1366-adds-thumbnails-in-packed-item branch from 92a6a51 to 9ba8867 Compare September 20, 2024 13:13
@ReidyT ReidyT changed the title feat: use Thumbnails from PackedItem in ItemCard feat: use Thumbnails from PackedItem Sep 20, 2024
@ReidyT ReidyT force-pushed the 1366-adds-thumbnails-in-packed-item branch from 534be1d to ba3e589 Compare September 20, 2024 13:26
@ReidyT ReidyT requested a review from pyphilia September 24, 2024 08:57
@ReidyT ReidyT force-pushed the 1366-adds-thumbnails-in-packed-item branch from b959ed4 to a1a6bb7 Compare September 24, 2024 09:20
pyphilia
pyphilia approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥾

cypress/e2e/item/authorization/itemLogin/utils.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ReidyT ReidyT force-pushed the 1366-adds-thumbnails-in-packed-item branch 3 times, most recently from 2b4a9ab to 6243c42 Compare September 27, 2024 07:43
@ReidyT @pyphilia
feat: use Thumbnails from PackedItem
8f56817 
* fix: update ThumbnailUploader to fix flickering warning tooltip
* feat: use ThumbnailUploader in ThumbnailSetting and remove ThumbnailWithControls
* feat: update ThumbnailCrop's delete button
* fix(test): include MUI Tooltip in optimizeDeps of vite.config
@pyphilia pyphilia force-pushed the 1366-adds-thumbnails-in-packed-item branch from 6243c42 to 8f56817 Compare September 27, 2024 09:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge September 27, 2024 09:15
@pyphilia pyphilia added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit a353659 Sep 27, 2024
4 checks passed
@pyphilia pyphilia deleted the 1366-adds-thumbnails-in-packed-item branch September 27, 2024 09:50
@graasper graasper mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@ReidyT ReidyT

Labels
v2.41.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReidyT @pyphilia