Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update item menu icons #1435

Merged
merged 5 commits into from
Sep 13, 2024
Merged

fix: update item menu icons #1435

merged 5 commits into from
Sep 13, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Sep 11, 2024 •
edited
Loading

based on #1434

  • fix: menu icons

@spaenleh spaenleh self-assigned this Sep 11, 2024
@spaenleh spaenleh added bug 🪲 Something isn't working ui labels Sep 11, 2024
@spaenleh spaenleh force-pushed the udpate-item-menu-icons branch from a2e58f0 to 83f52f3 Compare September 11, 2024 14:15
@spaenleh spaenleh force-pushed the udpate-item-menu-icons branch from 83f52f3 to 4b1ad9d Compare September 12, 2024 06:41
@spaenleh spaenleh requested review from pyphilia and ReidyT September 12, 2024 11:26
ReidyT
ReidyT approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, LGTM! I just let two comments 😄

src/components/common/DeleteButton.tsx Outdated Show resolved Hide resolved
src/components/common/RestoreButton.tsx Outdated Show resolved Hide resolved
src/components/main/ItemMenuContent.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pyphilia
pyphilia approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎨

src/components/item/header/Actions.tsx Show resolved Hide resolved
@spaenleh spaenleh added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit ca3e099 Sep 13, 2024
4 checks passed
@graasper graasper mentioned this pull request Sep 12, 2024
Merged
@pyphilia pyphilia deleted the udpate-item-menu-icons branch September 19, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working ui v2.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaenleh @pyphilia @ReidyT