Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: udpate menu icons to lucide #1432

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: udpate menu icons to lucide #1432

merged 2 commits into from
Sep 11, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Sep 11, 2024 •
edited
Loading

In this PR I updated the icons of the main menu to use lucide alternatives, below is a before and after:

Screenshot 2024-09-11 at 11 37 30 Screenshot 2024-09-11 at 11 37 22

ref #1431

@spaenleh spaenleh requested review from pyphilia and ReidyT September 11, 2024 09:40
@spaenleh spaenleh self-assigned this Sep 11, 2024
@spaenleh spaenleh added bug 🪲 Something isn't working ui labels Sep 11, 2024
@spaenleh spaenleh mentioned this pull request Sep 11, 2024
Merged
ReidyT
ReidyT reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I'm just not sure to understand why the GraaspMain's open property take false or undefined.

src/components/main/Main.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit f14deae Sep 11, 2024
4 checks passed
@graasper graasper mentioned this pull request Aug 30, 2024
Merged
@spaenleh spaenleh deleted the update-menu-icons branch September 11, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working ui v2.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @ReidyT