Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow user to request membership #1424

Merged
merged 5 commits into from
Sep 23, 2024
Merged

feat: allow user to request membership #1424

merged 5 commits into from
Sep 23, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Aug 27, 2024 •
edited
Loading

In this PR I tried to simplify a bit the code, by removing the use of the ItemLoginAuthorization black box.

It also has:

  • button to request access to an item
  • table to manage requests

TODO

  • update for enroll process

close #1423

@pyphilia
Copy link
Contributor Author

Screenshot 2024-08-30 at 16 01 44

@pyphilia pyphilia marked this pull request as ready for review September 11, 2024 07:34
@pyphilia pyphilia requested review from spaenleh and ReidyT September 11, 2024 07:34
spaenleh
spaenleh previously requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! I have added a few comments to improve some parts. Feel free to put them as issues if they are too large to handle in this PR.

Great work on the refactoring of the code ! 💪

cypress/e2e/item/authorization/forbidden.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/authorization/itemLogin/itemLogin.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/memberships/membershipRequestTable.cy.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/item/sharing/csvImport/ImportUsersWithCSVButton.tsx Outdated Show resolved Hide resolved
src/components/pages/item/accessWrapper/EnrollContent.tsx Outdated Show resolved Hide resolved
src/components/pages/item/accessWrapper/ItemAccessWrapper.tsx Outdated Show resolved Hide resolved
src/components/pages/item/accessWrapper/ItemAccessWrapper.tsx Show resolved Hide resolved
src/components/pages/item/accessWrapper/RequestAccessContent.tsx Outdated Show resolved Hide resolved
src/components/pages/item/accessWrapper/RequestAccessContent.tsx Outdated Show resolved Hide resolved
ReidyT
ReidyT requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it's a great refactor 🙌 I agree with what Basile said and I also let a few comments. Except for that, it looks good to me 🤠

cypress/e2e/item/authorization/itemLogin/itemLogin.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/authorization/itemLogin/itemLogin.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/authorization/itemLogin/itemLogin.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/authorization/itemLogin/itemLoginSetting.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/authorization/itemLogin/itemLoginSetting.cy.ts Outdated Show resolved Hide resolved
src/components/pages/item/accessWrapper/RequestAccessContent.tsx Outdated Show resolved Hide resolved
src/components/pages/item/accessWrapper/RequestAccessContent.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia force-pushed the 1423-membership-request branch from 8898158 to 69d9207 Compare September 23, 2024 08:46
@pyphilia pyphilia requested a review from ReidyT September 23, 2024 13:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@pyphilia pyphilia merged commit ddb0012 into main Sep 23, 2024
3 of 4 checks passed
@pyphilia pyphilia deleted the 1423-membership-request branch September 23, 2024 14:12
@graasper graasper mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh left review comments

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees
No one assigned
Labels
v2.39.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request access to item
3 participants
@pyphilia @spaenleh @ReidyT