Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent modal calls on selection #1387

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix: prevent modal calls on selection #1387

merged 2 commits into from
Jul 31, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Jul 29, 2024 •
edited
Loading

Selecting items trigger lots of renders.

  • Moved down DragSelection (so some duplication happens). Some manual adjustement is necessary because of margin and padding.
  • do not fetch items for modal if they are not opened.

@pyphilia pyphilia self-assigned this Jul 29, 2024
@pyphilia pyphilia marked this pull request as ready for review July 29, 2024 13:27
@pyphilia pyphilia requested review from spaenleh and ReidyT and removed request for spaenleh July 29, 2024 13:27
spaenleh
spaenleh approved these changes Jul 31, 2024
View reviewed changes
src/components/item/FolderContent.tsx Outdated Show resolved Hide resolved
src/components/main/list/useDragSelection.tsx Outdated Show resolved Hide resolved
ReidyT
ReidyT approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👑

src/components/pages/RecycledItemsScreen.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia added this pull request to the merge queue Jul 31, 2024
@pyphilia pyphilia removed this pull request from the merge queue due to a manual request Jul 31, 2024
@pyphilia pyphilia force-pushed the prevent-modal-calls branch from 6e60425 to b27a88d Compare July 31, 2024 14:51
@pyphilia pyphilia enabled auto-merge July 31, 2024 14:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit f78bb18 Jul 31, 2024
4 checks passed
@graasper graasper mentioned this pull request Jul 31, 2024
Merged
@pyphilia pyphilia deleted the prevent-modal-calls branch July 31, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
v2.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyphilia @spaenleh @ReidyT