feat: remove outdated state from the frontend #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyphilia
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Thanks for all the changes!
- I'm actually wondering whether
validateis still clear as a word on its own. Maybe we should be clearer like "Run verifications" (not good suggestion). Do you have any ideas? Or maybe an info icon to say which verifications we do. - Plus it's not that clear that clicking on "validate" will actually publish the item. Maybe it should be rather "Validate & Publish"? Actually I think I'm okay with a button "publish" and have the status be "verification in progress" that will then become green once the validation is done.
- I think it's a bit weird the "unpublish" is sometimes on the left or the right of the "contained" button. Maybe we should have the "unpublish" action be separated, like "destructive settings" of github?
Otherwise I'm all good with the code!
spaenleh
approved these changes
Jul 23, 2024
|
After discussing with @pyphilia @spaenleh, the state outdate is not useful now because it doesn't check the children and nothing happen in the library. This state can be removed for now. We should think about a better way to handle updates (like revalidating at each change or freezing the published item and asking to publish the changes in the library, kind of Snapshot pattern). |
ReidyT
force-pushed
the
1296-add-unpublish-button-in-outdated
branch
from
a4b5ba6 to
d9f6414
Compare
ReidyT
changed the title
ReidyT
force-pushed
the
1296-add-unpublish-button-in-outdated
branch
from
626b550 to
bb3105c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After a discussion, the state outdate is not useful now because it doesn't check the children and nothing happen in the library. This state can be removed for now. We should think about a better way to handle updates (like revalidating at each change or freezing the published item and asking to publish the changes in the library, kind of Snapshot pattern).
Outdated issue
I've added an "Unpublish" button to the Outdated state to provide more flexibility. Additionally, I've updated the
ReadyToPublishstate to more closely resemble theUnpublishedstate for better user experience.Taking advantage of the backend change in graasp/graasp#1226 where the state is now returned as
Unpublishedinstead ofOutdatedfor oudated items removed from the Library, I've also updated the visual appearance of the ReadyToPublish state.The previous
ReadyToPublishlook could be misleading if the item had been unpublished (video 1). Furthermore, the transition fromReadyToPublishtoUnpublishedcan be surprising (video 2).The new ReadyToPublish design (video 3) offers a more consistent and intuitive user experience by aligning it closer to the Unpublished state. This change reduces potential user frustration and improves overall clarity.
demo1.mov
demo2.mov
demo3.mov