Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent changing visibility published item #1359

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: prevent changing visibility published item #1359

merged 1 commit into from
Jul 22, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Jul 18, 2024 •
edited
Loading

image

@ReidyT ReidyT self-assigned this Jul 18, 2024
@ReidyT ReidyT marked this pull request as ready for review July 18, 2024 11:39
@ReidyT ReidyT requested review from pyphilia and spaenleh July 18, 2024 11:46
@ReidyT ReidyT linked an issue Jul 18, 2024 that may be closed by this pull request
Prevent changing visibility once the item is published #1253
Closed
@ReidyT ReidyT force-pushed the 1253-prevent-changing-visibility-published-item branch from 09ec891 to 0f09a98 Compare July 18, 2024 15:11
spaenleh
spaenleh approved these changes Jul 19, 2024
View reviewed changes
cypress/e2e/item/share/changeVisibility.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/share/changeVisibility.cy.ts Outdated Show resolved Hide resolved
@ReidyT ReidyT force-pushed the 1253-prevent-changing-visibility-published-item branch from 1fe7e02 to 4fa2a8f Compare July 22, 2024 06:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
13.1% Duplication on New Code

See analysis details on SonarCloud

@ReidyT ReidyT added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 723547b Jul 22, 2024
4 checks passed
@graasper graasper mentioned this pull request Jul 22, 2024
Merged
@ReidyT ReidyT deleted the 1253-prevent-changing-visibility-published-item branch July 22, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@ReidyT ReidyT

Labels
v2.33.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent changing visibility once the item is published
2 participants
@ReidyT @spaenleh