Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add member validation alert #1350

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jul 16, 2024

In this PR I add the member validation banner to alert users that their account needs to be validated.

Below is a screenshot.

Users have the possibility to close the banner, it will not be shown unless they reload the page.
Screenshot 2024-07-16 at 08 07 38

WARNING (happens only on local dev)
I have a small issue with the text not being updated when the language changes. Not sure if this is a change I did or if it was there before.

fixes #1339

@spaenleh spaenleh self-assigned this Jul 16, 2024
@spaenleh spaenleh marked this pull request as draft July 16, 2024 06:16
src/components/main/Main.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, LGTM! 🚀

src/components/alerts/MemberValidationBanner.tsx Outdated Show resolved Hide resolved
src/components/alerts/MemberValidationBanner.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

src/components/alerts/MemberValidationBanner.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh force-pushed the 1339-member-validation-banner branch from fc3a890 to d0aa3ac Compare July 22, 2024 13:58
Copy link

@spaenleh spaenleh added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 110bf1c Jul 22, 2024
4 checks passed
@pyphilia pyphilia deleted the 1339-member-validation-banner branch August 5, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a banner when member is not validated
4 participants