Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow current geoloc on map #1314

Merged
merged 11 commits into from
Jul 5, 2024
Merged

fix: allow current geoloc on map #1314

merged 11 commits into from
Jul 5, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Jul 1, 2024

The geolocation didn't work because the status in safari can be prompt which was not handled.
Additionally the logic was not working in ios because navigator.permissions doesn't exist.

(the current location position was never fetched from the mobile because the url query was not set, but that's a pb in the mobile)

@pyphilia pyphilia self-assigned this Jul 1, 2024
@pyphilia pyphilia requested review from spaenleh and LinaYahya July 1, 2024 08:44
@pyphilia pyphilia marked this pull request as ready for review July 1, 2024 08:47
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if you can make the tests pass 😉

Copy link

sonarqubecloud bot commented Jul 4, 2024

@pyphilia pyphilia added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 4fda73c Jul 5, 2024
5 checks passed
@spaenleh spaenleh deleted the geoloc-debug branch July 15, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants