Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alignment and sizing settings #1300

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jun 26, 2024

In this PR I added an alignment setting and correct image sizing options.

Screen.Recording.2024-06-27.at.17.26.48.mov

And they are also available in the settings list:

Screenshot 2024-06-27 at 09 25 33

@spaenleh spaenleh self-assigned this Jun 26, 2024
@spaenleh spaenleh requested a review from pyphilia June 27, 2024 06:44
@spaenleh spaenleh force-pushed the add-image-alignment-setting branch from fc62961 to eb243f2 Compare June 27, 2024 07:07
@spaenleh spaenleh added the feature New feature or request label Jun 27, 2024
@spaenleh spaenleh changed the title fix: add alignment and sizing settings feat: add alignment and sizing settings Jun 27, 2024
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think I would maybe have a visual wrapper around the settings when displayed in the item screen? And have it below?

src/components/item/settings/FileSettings.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh force-pushed the add-image-alignment-setting branch from b7ef8db to 6a09ca7 Compare June 27, 2024 09:29
@spaenleh spaenleh force-pushed the add-image-alignment-setting branch from 2973c21 to cf1849b Compare June 28, 2024 11:12
Copy link

@spaenleh spaenleh enabled auto-merge June 28, 2024 16:03
@spaenleh spaenleh added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 4ef2378 Jun 28, 2024
4 checks passed
@pyphilia pyphilia deleted the add-image-alignment-setting branch August 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v2.30.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants