Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't allow none folder items to be published #1284

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: don't allow none folder items to be published #1284

merged 1 commit into from
Jun 13, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Jun 11, 2024 •
edited
Loading

  • also improve the description components of the status button
Screenshot 2024-06-11 at 15 37 52 Screenshot 2024-06-11 at 15 37 31 Screenshot 2024-06-11 at 15 37 15 Screenshot 2024-06-11 at 15 36 51 Screenshot 2024-06-11 at 15 36 30 Screenshot 2024-06-11 at 15 34 41 Screenshot 2024-06-11 at 15 33 28 Screenshot 2024-06-11 at 15 31 36 image

@ReidyT ReidyT self-assigned this Jun 11, 2024
@ReidyT ReidyT requested review from spaenleh and pyphilia June 11, 2024 14:06
pyphilia
pyphilia requested changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!
Actually I wonder if it wouldn't be better to hide the publication page completely for given types? Or just show a text, instead of providing the form on the left but it's unnecessary to fill?

cypress/e2e/item/publish/publishedItem.cy.ts Outdated Show resolved Hide resolved
src/components/hooks/usePublicationStatus.tsx Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
@ReidyT ReidyT requested a review from pyphilia June 13, 2024 07:00
@ReidyT
feat: restrict publication to folders only
5871b40 
  - feat: improve the description components of the status button
  - feat: hide publication preview if type cannot be published
  - chore(dep): update sdk to 4.13.0
@ReidyT ReidyT force-pushed the 1106-restrict-publication-folders-only branch from abb2d95 to 5871b40 Compare June 13, 2024 13:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 9c737dd Jun 13, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
@ReidyT ReidyT deleted the 1106-restrict-publication-folders-only branch June 14, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@ReidyT ReidyT

Labels
v2.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReidyT @pyphilia