Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link default to use showLinkButton = false #1266

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jun 6, 2024

The default link type is a bare link, but when not specified the backend creates a link with the showLinkButton to true. The default setting was added in the frontend to give the expected result.

The default link type is a bare link, but when not specified the backend
creates a link with the showLinkButton to true. The default setting was
added in the frontend to give the expected result.
@spaenleh spaenleh requested review from pyphilia and ReidyT June 6, 2024 13:51
@spaenleh spaenleh self-assigned this Jun 6, 2024
@spaenleh spaenleh added the bug 🪲 Something isn't working label Jun 6, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit fcba8e6 Jun 7, 2024
4 checks passed
@spaenleh spaenleh deleted the fix-link-default branch June 10, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v2.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants