Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle automatic publication after validation #1265

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Jun 5, 2024

Update the frontend to be compatible with (graasp/graasp#1077).

  • Ask the user to set item to public during the validation (but will be public only if succeeded)
  • refactor the PublicationButton into smaller components.

@ReidyT ReidyT self-assigned this Jun 5, 2024
@ReidyT ReidyT requested review from pyphilia and spaenleh June 7, 2024 06:48
@ReidyT ReidyT force-pushed the 1077-publish-automatically-when-item-validated branch 2 times, most recently from 47e5665 to 98ee04e Compare June 7, 2024 09:41
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor ! I have added some comments where I think we can improve a bit.

This really shows how much boiler plate you have to write sometimes. But this is a lot better than what was before I could see !

@ReidyT ReidyT force-pushed the 1077-publish-automatically-when-item-validated branch from d266a19 to cade200 Compare June 10, 2024 09:38
@ReidyT ReidyT requested a review from spaenleh June 10, 2024 10:02
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@ReidyT ReidyT added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 565bbcc Jun 10, 2024
4 checks passed
@ReidyT ReidyT deleted the 1077-publish-automatically-when-item-validated branch June 10, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants