-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle automatic publication after validation #1265
Conversation
47e5665
to
98ee04e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor ! I have added some comments where I think we can improve a bit.
This really shows how much boiler plate you have to write sometimes. But this is a lot better than what was before I could see !
src/components/item/publish/publicationButtons/PublicationButton.tsx
Outdated
Show resolved
Hide resolved
src/components/item/publish/publicationButtons/PublicationButton.hook.tsx
Outdated
Show resolved
Hide resolved
src/components/item/publish/publicationButtons/PublicationButton.tsx
Outdated
Show resolved
Hide resolved
src/components/item/publish/publicationButtons/PublicationButton.tsx
Outdated
Show resolved
Hide resolved
src/components/item/publish/publicationButtons/PublicationButton.tsx
Outdated
Show resolved
Hide resolved
src/components/item/publish/publicationButtons/PublishedChildrenButton.tsx
Outdated
Show resolved
Hide resolved
src/components/item/publish/publicationButtons/NotPublicButton.tsx
Outdated
Show resolved
Hide resolved
src/components/item/publish/publicationButtons/ReadyToPublishButton.tsx
Outdated
Show resolved
Hide resolved
- warn the user that the item will set it to publish after the validation
d266a19
to
cade200
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
Update the frontend to be compatible with (graasp/graasp#1077).