Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add query param for mode #1246

Merged
merged 5 commits into from
May 23, 2024
Merged

feat: add query param for mode #1246

merged 5 commits into from
May 23, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented May 22, 2024 •
edited
Loading

Handle query param to keep track of the view mode.
It also simplifies tests, so I might change all of them in a next PR.

close #1245

@pyphilia pyphilia self-assigned this May 22, 2024
@pyphilia pyphilia marked this pull request as ready for review May 22, 2024 14:28
@pyphilia pyphilia requested review from LinaYahya, spaenleh and ReidyT May 22, 2024 14:28
spaenleh
spaenleh approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I suggest using URLSearchParams and builders when possible.

I like where this is going !

src/components/item/sharing/shortLink/ShortLinksRenderer.tsx Outdated Show resolved Hide resolved
src/components/pages/item/ItemPageLayout.tsx Outdated Show resolved Hide resolved
src/config/externalPaths.ts Outdated Show resolved Hide resolved
src/config/paths.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue May 23, 2024
@pyphilia pyphilia removed this pull request from the merge queue due to a manual request May 23, 2024
@pyphilia pyphilia added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 279193e May 23, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 23, 2024
Merged
@spaenleh spaenleh deleted the 1245-view-param branch May 29, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@pyphilia pyphilia

Labels
v2.23.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add query param for view
2 participants
@pyphilia @spaenleh