Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve table and views #1215

Merged
merged 7 commits into from
Jul 12, 2024
Merged

feat: improve table and views #1215

merged 7 commits into from
Jul 12, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented May 3, 2024 •
edited
Loading

This PR includes the following features:

  • drag and drop to upload in between rows
  • drag and drop in items to move inside
  • drop files in between items to upload in between
  • drag and drop reorder (backend: saved in the item)
  • improved table layout - merged with the grid layout as not-dense

notes:

  • added new button at the end of tables. I reverted the fab button because it was colliding with the chatbox when it is opened...

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia force-pushed the new-table branch 2 times, most recently from 0a30306 to df99ef5 Compare July 1, 2024 11:42
@pyphilia pyphilia marked this pull request as ready for review July 9, 2024 10:02
@pyphilia pyphilia requested review from spaenleh and ReidyT July 9, 2024 10:02
ReidyT
ReidyT approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes 🫠 ! Really good job 👑, it looks good to me, I just let some comments :)

cypress/e2e/item/bookmarks/bookmarks.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/bookmarks/bookmarks.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/bookmarks/bookmarks.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/bookmarks/bookmarks.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/bookmarks/bookmarks.cy.ts Show resolved Hide resolved
src/components/item/header/ItemHeader.tsx Show resolved Hide resolved
src/components/map/useCurrentLocation.tsx Outdated Show resolved Hide resolved
src/components/pages/HomeScreen.tsx Outdated Show resolved Hide resolved
src/components/table/useSorting.tsx Outdated Show resolved Hide resolved
src/config/selectors.ts Show resolved Hide resolved
spaenleh
spaenleh approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow ! huge PR ! I have left a few comments. I think we will be better off merging once fixed and then iterating over this clean base !

GG for the work ! 💪

cypress/e2e/item/bookmarks/bookmarks.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/edit/editLink.cy.ts Show resolved Hide resolved
cypress/e2e/item/home/home.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/home/home.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/home/home.cy.ts Outdated Show resolved Hide resolved
src/components/item/sharing/shortLink/PlatformIcon.tsx Outdated Show resolved Hide resolved
src/components/pages/PublishedItemsScreen.tsx Outdated Show resolved Hide resolved
src/components/pages/RecycledItemsScreen.tsx Outdated Show resolved Hide resolved
src/components/table/ItemNameCellRenderer.tsx Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
@pyphilia pyphilia enabled auto-merge July 12, 2024 14:25
spaenleh
spaenleh reviewed Jul 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/Root.tsx Outdated Show resolved Hide resolved
src/components/Root.tsx Outdated Show resolved Hide resolved
src/components/pages/PageWrapper.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia disabled auto-merge July 12, 2024 14:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge July 12, 2024 14:46
@pyphilia pyphilia added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 57da3f3 Jul 12, 2024
5 checks passed
@graasper graasper mentioned this pull request Jul 12, 2024
Merged
@spaenleh spaenleh deleted the new-table branch July 15, 2024 05:27
@pyphilia pyphilia mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@ReidyT ReidyT ReidyT approved these changes

Assignees
No one assigned
Labels
v2.31.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyphilia @spaenleh @ReidyT