Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send mobile-app param to map #1202

Merged
merged 12 commits into from
May 1, 2024
Merged

feat: send mobile-app param to map #1202

merged 12 commits into from
May 1, 2024

Conversation

pyphilia
Copy link
Contributor

Pass mobileApp param to the map to handle open in player.

@pyphilia pyphilia self-assigned this Apr 29, 2024
// todo: replace with universal/deep link? not sure it works inside iframe..
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error
window.ReactNativeWebView.postMessage(

Check failure

Code scanning / SonarCloud

Origins should be verified during cross-origin communications High

Specify a target origin for this message. See more on SonarCloud
@pyphilia pyphilia marked this pull request as ready for review April 30, 2024 15:52
@pyphilia pyphilia requested a review from spaenleh April 30, 2024 15:52
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@pyphilia pyphilia merged commit c041a99 into main May 1, 2024
3 of 4 checks passed
@pyphilia pyphilia deleted the mobile-app branch May 1, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants