Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete item thumbnail #1168

Merged
merged 9 commits into from
Apr 23, 2024
Merged

feat: delete item thumbnail #1168

merged 9 commits into from
Apr 23, 2024

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Apr 18, 2024 •
edited
Loading

closes #1155

Screenshot from 2024-04-18 15-39-54

@LinaYahya LinaYahya self-assigned this Apr 18, 2024
@LinaYahya LinaYahya marked this pull request as ready for review April 19, 2024 07:39
@LinaYahya LinaYahya requested review from spaenleh and pyphilia April 19, 2024 07:40
pyphilia
pyphilia requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think we can improve the hover event with some css, let me know if you can't make it 🦆

package.json Outdated Show resolved Hide resolved
src/components/item/settings/ThumbnailSetting.tsx Outdated Show resolved Hide resolved
src/components/item/settings/ThumbnailSetting.tsx Outdated Show resolved Hide resolved
src/components/item/settings/ThumbnailWithDeleteButton.tsx Outdated Show resolved Hide resolved
src/components/item/settings/ThumbnailWithDeleteButton.tsx Outdated Show resolved Hide resolved
@LinaYahya LinaYahya requested a review from pyphilia April 22, 2024 17:36
pyphilia
pyphilia requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a change for a test, and update the yarn lock, and that should be good!

cypress/e2e/item/settings/thumbnail.cy.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LinaYahya LinaYahya requested a review from pyphilia April 23, 2024 09:10
@pyphilia pyphilia merged commit d4e36c8 into main Apr 23, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
@pyphilia pyphilia deleted the 1155-delete-item-thumbnail branch April 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh Awaiting requested review from spaenleh

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@LinaYahya LinaYahya

Labels
v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow item thumbnail deletion
2 participants
@LinaYahya @pyphilia