Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use builder modal for new item with map #1147

Merged
merged 4 commits into from
Apr 15, 2024
Merged

feat: use builder modal for new item with map #1147

merged 4 commits into from
Apr 15, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Apr 15, 2024 •
edited
Loading

  • update map (current location)
  • include new item modal and use it with the map
Screen.Recording.2024-04-15.at.14.10.50.mov

@pyphilia pyphilia self-assigned this Apr 15, 2024
@pyphilia pyphilia requested review from spaenleh and ReidyT April 15, 2024 12:12
@pyphilia pyphilia marked this pull request as ready for review April 15, 2024 12:25
@pyphilia pyphilia changed the title feat: use builder modal on map, provide current location feat: use builder modal for new item with map Apr 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

spaenleh
spaenleh approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@pyphilia pyphilia enabled auto-merge April 15, 2024 13:15
@pyphilia pyphilia added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 27155c6 Apr 15, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
@spaenleh spaenleh deleted the current-location-map branch April 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@pyphilia pyphilia

Labels
v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh