-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add structure import from csv #1138
Conversation
fa1b4e4
to
1175f56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks nice, I will check this PR ! I just have few questions about the videos:
- In the first one, why test 1 is not imported in the permission list ?
- In general, could it be possible to add a preview of what the CSV will do ? For example, just listing the mails of the invited users in the first video and displaying the preview before confirming in the second one ? It is just a suggestion but it could be interesting I think.
@ReidyT Thank you for the comment.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice PR ! LGTM I just le some comments 🫠
src/components/item/sharing/csvImport/DisplayInvitationSummary.tsx
Outdated
Show resolved
Hide resolved
src/components/item/sharing/csvImport/DisplayInvitationSummary.tsx
Outdated
Show resolved
Hide resolved
src/components/item/sharing/csvImport/ImportUsersDialogContent.tsx
Outdated
Show resolved
Hide resolved
src/components/item/sharing/csvImport/ImportUsersDialogContent.tsx
Outdated
Show resolved
Hide resolved
src/components/item/sharing/csvImport/ImportUsersDialogContent.tsx
Outdated
Show resolved
Hide resolved
e1090fb
to
58e95f8
Compare
Quality Gate passedIssues Measures |
This PR adds support for the new import CSV feature.
In general:
group_name
column, then the user has the possibility to select an item that will be used as the template for the groups.In the following video, I import a file that results in 1 membership and 1 invitation.
import.users.csv.mov
import.groups.mov