Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update map for mobile use #1130

Merged
merged 3 commits into from
Apr 11, 2024
Merged

feat: update map for mobile use #1130

merged 3 commits into from
Apr 11, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Apr 4, 2024

This PR adds a new route /map that will display the map "in full screen". This is used by the mobile app to display the map.

@pyphilia pyphilia self-assigned this Apr 4, 2024
@pyphilia pyphilia marked this pull request as ready for review April 5, 2024 13:07
@pyphilia pyphilia requested review from spaenleh and ReidyT April 5, 2024 13:07
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some questions

src/components/item/MapView.tsx Outdated Show resolved Hide resolved
src/config/paths.ts Show resolved Hide resolved
src/components/App.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 05c779e Apr 11, 2024
5 checks passed
@spaenleh spaenleh deleted the mobile-map branch April 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants