Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skeleton for modal #1083

Merged
merged 2 commits into from
Mar 19, 2024
Merged

feat: add skeleton for modal #1083

merged 2 commits into from
Mar 19, 2024

Conversation

pyphilia
Copy link
Contributor

I added some skeletons because I've noticed it shows nothing on loading, so I thought it was broken. But not, it was just laggy.

Screen.Recording.2024-03-13.at.17.24.02.mov

@pyphilia pyphilia requested review from spaenleh and LinaYahya March 13, 2024 16:29
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 26a7e53 Mar 19, 2024
5 checks passed
@spaenleh spaenleh deleted the modal-skeleton branch March 20, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants