Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename favorite to bookmark #1082

Merged
merged 3 commits into from
Mar 13, 2024
Merged

feat: rename favorite to bookmark #1082

merged 3 commits into from
Mar 13, 2024

Conversation

pyphilia
Copy link
Contributor

close #799

@pyphilia pyphilia requested review from spaenleh and LinaYahya March 13, 2024 13:14
@pyphilia pyphilia self-assigned this Mar 13, 2024
@pyphilia pyphilia enabled auto-merge March 13, 2024 13:37
@pyphilia pyphilia disabled auto-merge March 13, 2024 13:37
@pyphilia pyphilia enabled auto-merge March 13, 2024 14:19
spaenleh
spaenleh approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, I am just a bit worried about the change of the route.
There are some translations that have not been changed. We need to ensure that everything is coherent.
Are we planning to also change the icon ? Maybe this can be done later ?

src/components/common/BookmarkButton.tsx Outdated Show resolved Hide resolved
src/components/main/ItemCard.tsx Outdated Show resolved Hide resolved
src/components/main/ItemMenu.tsx Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
@pyphilia
Copy link
Contributor Author

I've already changed the icons, done in graasp-ui and some places in builder.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 4cc6a4c Mar 13, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Merged
@spaenleh spaenleh deleted the 799-bookmark branch March 20, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

Assignees

@pyphilia pyphilia

Labels
v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename favorites to bookmarks
2 participants
@pyphilia @spaenleh