Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add checkbox in DescriptionForm to allow to add description above #1050

Merged
merged 8 commits into from
Mar 7, 2024
Merged

feat: add checkbox in DescriptionForm to allow to add description above #1050

merged 8 commits into from
Mar 7, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Mar 4, 2024 •
edited
Loading

image image

@ReidyT ReidyT requested review from pyphilia and spaenleh March 4, 2024 13:44
@ReidyT ReidyT self-assigned this Mar 4, 2024
@ReidyT ReidyT added the feature New feature or request label Mar 4, 2024
@ReidyT ReidyT force-pushed the 694-display-description-above-or-below-item branch from 7dddd28 to 5c7a058 Compare March 4, 2024 13:45
pyphilia
pyphilia requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you have a select of enum instead of a checkbox? I think it also matches better your type for descriptionPlacement that is Above or Below. I don't think we will add left and right, but I think it's also clearer to the user if the default select is set on below.

@ReidyT ReidyT requested a review from pyphilia March 5, 2024 07:31
@ReidyT ReidyT force-pushed the 694-display-description-above-or-below-item branch from 27d4c7d to 1a4fe1e Compare March 6, 2024 07:45
pyphilia
pyphilia requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's apply the changes as discussed on slack ;)

src/components/item/form/DescriptionForm.tsx Outdated Show resolved Hide resolved
@ReidyT ReidyT requested a review from pyphilia March 6, 2024 14:30
@ReidyT ReidyT force-pushed the 694-display-description-above-or-below-item branch from 0c3d8c5 to ea981e7 Compare March 6, 2024 14:32
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.8% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge March 7, 2024 14:28
@pyphilia pyphilia added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit a38f27d Mar 7, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Merged
@pyphilia pyphilia deleted the 694-display-description-above-or-below-item branch March 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@ReidyT ReidyT

Labels
feature New feature or request v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReidyT @pyphilia