fix: update deploy to use VITE_GRAASP_ASSETS_URL variable #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
force-pushed
the
877-fix-assets-secret
branch
from
096ecc6 to
e7c5154
Compare
|
pyphilia
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
VITE_GRAASP_ASSETS_URLto be a vars and set the value in the repo (done)AWS_S3_BUCKET_NAMEto be a vars and update repo values (done)CLOUDFRONT_DISTRIBUTION_IDto be a vars and update repo value (done)After the PR is deployed to prod, we will be able to remove the repo vars that have suffixes in _DEV, ...