fix: update un-publish process to reflect changes #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
force-pushed
the
fix-update-on-unpublish
branch
2 times, most recently
from
cd0335d to
3c9f618
Compare
spaenleh
changed the title
spaenleh
force-pushed
the
fix-update-on-unpublish
branch
from
3c9f618 to
51bbed7
Compare
ReidyT
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
This PR seems to be ok for me 😄, I just let a comment to potentially solve the issue (maybe not).
I don't think the problem is serious, but depending on the possible latency between the two states (loading and deactivated), it may adversely affect the user experience.
spaenleh
force-pushed
the
fix-update-on-unpublish
branch
from
51bbed7 to
3ad9824
Compare
|
|
@ReidyT I updated the code following your comment. The recording has also been updated. Let me know if it is better that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See below is an extreme slow-mo of the button.
there is still an issue where while the fetching for the new itemPublish info is loading the state appears as not published... lets see if it is an issue or not.
Screen.Recording.2024-02-21.at.10.00.25.mov