This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
feat: add graasp branding and show all platforms #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReidyT
suggested changes
Sep 12, 2024
There was a problem hiding this comment.
Thanks for this PR! I really like it 🔥. I tried to reverse some of them, but finally I think it's better the way you did.
I would just add more top and left margin to the branding. Also, on mobile, I'm not a big fan of having the branding and the Graasp icon above the login. Maybe we could merge the two on mobile?
Also, it's possible I misunderstood, but I thought we should avoid the * in the placeholder, shouldn't we?
spaenleh
approved these changes
Sep 13, 2024
pyphilia
temporarily deployed
to
development
GitHub Actions
Inactive
|
ReidyT
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have something simpler, I chose to show all platforms at once. I've added a "Graasp" branding at the top so it's clear it's within the Graasp domain.
close #448