Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

feat: show different success message for password on success, refactor #413

Merged
merged 7 commits into from
Sep 11, 2024
Merged

feat: show different success message for password on success, refactor #413

merged 7 commits into from
Sep 11, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented May 27, 2024 •
edited by ReidyT
Loading

  • Split the Sign in files between magic link and password.
  • Have /signin/success?email= for success path
  • Does not redirect to success for password, instead shows success alert.
Screenshot 2024-05-27 at 13 55 59

image

close #411

@pyphilia pyphilia requested review from spaenleh and ReidyT May 27, 2024 11:55
@pyphilia pyphilia self-assigned this May 27, 2024
ReidyT
ReidyT approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR ! LGTM 😄. I just let some comments that could improve the code in my sense.

cypress/e2e/SignInPassword.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/SignIn.cy.ts Outdated Show resolved Hide resolved
src/components/MagicLinkSuccessContent.tsx Show resolved Hide resolved
src/components/MagicLinkSuccessContent.tsx Outdated Show resolved Hide resolved
src/components/SignIn.tsx Outdated Show resolved Hide resolved
src/components/SignInPasswordForm.tsx Outdated Show resolved Hide resolved
src/components/MagicLinkForm.tsx Show resolved Hide resolved
src/components/MagicLinkForm.tsx Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

spaenleh
spaenleh reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this locally, it looks good, do you want me to take a closer look at the code ? is it ready for review ?

@pyphilia pyphilia changed the title feat: show differnt success message for password on success, refactor feat: show different success message for password on success, refactor Sep 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 606cc7a Sep 11, 2024
3 checks passed
@graasper graasper mentioned this pull request Sep 11, 2024
Merged
@pyphilia pyphilia deleted the 411-password branch September 11, 2024 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@spaenleh spaenleh spaenleh left review comments

Assignees

@pyphilia pyphilia

@ReidyT ReidyT

Labels
v2.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should show special message instead of mail message on successful password login
3 participants
@pyphilia @spaenleh @ReidyT