Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

feat: add enable analytics checkbox for signup #361

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Apr 5, 2024

This code is an updated version of #70.

In this version, a checkbox is used instead of a switch to follow the same UI as for the user agreements:

image

@ReidyT ReidyT self-assigned this Apr 5, 2024
@ReidyT ReidyT linked an issue Apr 5, 2024 that may be closed by this pull request
@ReidyT ReidyT marked this pull request as ready for review April 5, 2024 08:08
@ReidyT ReidyT requested review from pyphilia and spaenleh April 5, 2024 08:08
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I would maybe like to have a longer text for Enable Analytics, not sure what. From chatgpt: Activate data-driven insights saving for enhanced analytics dashboards. You can shorten aha 🚋

cypress/e2e/SignUp.cy.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
src/hooks/useEnableAnalyticsForm.tsx Outdated Show resolved Hide resolved
@ReidyT ReidyT force-pushed the 67-add-enable-analytics-switch-for-signup branch from 72db00a to 151fdcc Compare April 11, 2024 07:22
@ReidyT ReidyT force-pushed the 67-add-enable-analytics-switch-for-signup branch from f3d3f90 to a986b9c Compare April 16, 2024 12:08
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ReidyT ReidyT enabled auto-merge April 16, 2024 12:09
@ReidyT ReidyT added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 201c445 Apr 16, 2024
3 checks passed
@ReidyT ReidyT deleted the 67-add-enable-analytics-switch-for-signup branch April 16, 2024 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add switch to opt-in/opt-out of action saving
3 participants