Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider query strings for context #83

Open
pyphilia opened this issue Apr 27, 2023 · 2 comments
Open

Consider query strings for context #83

pyphilia opened this issue Apr 27, 2023 · 2 comments
Labels
feature New feature or request

Comments

@pyphilia
Copy link
Contributor

It would be really convenient to be able to set some value via querystrings such as language, view, mode, etc.
This would force the app in a particular context (it would be be prioritised compared to the parent's context).

@pyphilia pyphilia added the feature New feature or request label Apr 27, 2023
@spaenleh
Copy link
Member

I agree, but with the recent changes, this would have to either go in:

  • graasp/ui: where the communication and the context is given to the app (inside the AppItem component)
  • builder/player: where the AppItem is instantiated and the contextPayload is created. This was done to remove the need to pass a lot of props to the AppItem component.

But I guess we should extract as much logic from ui as possible.

@codeofmochi
Copy link
Contributor

I don't think this should be in UI either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants